Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #3579: Set Intents target version and version string correctly #3933

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Ref #3579: Set Intents target version and version string correctly #3933

merged 1 commit into from
Jul 16, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jul 16, 2021 •
edited by iccub
Loading

Summary of Changes

Fixes CFBundleVersion and CFBundleShortVersionString entries in the new Intents target Info.plist

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from iccub July 16, 2021 15:43
@kylehickinson kylehickinson added this to the 1.29 milestone Jul 16, 2021
@kylehickinson kylehickinson merged commit 4c40413 into development Jul 16, 2021
@kylehickinson kylehickinson deleted the intents-version branch July 16, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehickinson @iccub